wkulhanek/bonob
1
0
Fork 0
mirror of https://github.com/wkulhanek/bonob.git synced 2025-12-22 01:43:29 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity

Ability to see TopRated/starred albums (#63)

Browse Source
This commit is contained in:
Simon J
2021-10-08 00:08:32 +11:00
committed by GitHub
parent 6116975d7a
commit cc95beb4f2
6 changed files with 196 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
tests/subsonic.test.ts
View File

@@ -266,7 +266,7 @@ const maybeIdFromCoverArtId = (coverArt: string | undefined) =>
coverArt ? splitCoverArtId(coverArt)[1] : "";
const asAlbumJson = (
artist: Artist,
artist: { id: string | undefined, name: string | undefined },
album: AlbumSummary,
tracks: Track[] = []
) => ({
@@ -353,9 +353,9 @@ const getAlbumJson = (artist: Artist, album: Album, tracks: Track[]) =>
const getSongJson = (track: Track) => subsonicOK({ song: asSongJson(track) });
// const getStarredJson = ({ songIds }: { songIds: string[] }) => subsonicOK({starred2: {
// album: [],
// song: songIds.map((id) => ({ id })),
// const getStarredJson = ({ albums }: { albums: Album[] }) => subsonicOK({starred2: {
// album: albums.map(it => asAlbumJson({ id: it.artistId, name: it.artistName }, it, [])),
// song: [],
// }})
const subsonicOK = (body: any = {}) => ({
@@ -1389,11 +1389,13 @@ describe("Subsonic", () => {
describe("getting albums", () => {
describe("filtering", () => {
const album1 = anAlbum({ genre: asGenre("Pop") });
const album2 = anAlbum({ genre: asGenre("Rock") });
const album3 = anAlbum({ genre: asGenre("Pop") });
const album1 = anAlbum({ id: "album1", genre: asGenre("Pop") });
const album2 = anAlbum({ id: "album2", genre: asGenre("Rock") });
const album3 = anAlbum({ id: "album3", genre: asGenre("Pop") });
const album4 = anAlbum({ id: "album4", genre: asGenre("Pop") });
const album5 = anAlbum({ id: "album5", genre: asGenre("Pop") });
const artist = anArtist({ albums: [album1, album2, album3] });
const artist = anArtist({ albums: [album1, album2, album3, album4, album5] });
describe("by genre", () => {
beforeEach(() => {
@@ -1472,7 +1474,7 @@ describe("Subsonic", () => {
});
it("should pass the filter to navidrome", async () => {
const q: AlbumQuery = { _index: 0, _count: 100, type: "newest" };
const q: AlbumQuery = { _index: 0, _count: 100, type: "recentlyAdded" };
const result = await navidrome
.generateToken({ username, password })
.then((it) => it as AuthSuccess)
@@ -1522,7 +1524,7 @@ describe("Subsonic", () => {
});
it("should pass the filter to navidrome", async () => {
const q: AlbumQuery = { _index: 0, _count: 100, type: "recent" };
const q: AlbumQuery = { _index: 0, _count: 100, type: "recentlyPlayed" };
const result = await navidrome
.generateToken({ username, password })
.then((it) => it as AuthSuccess)
@@ -1567,7 +1569,7 @@ describe("Subsonic", () => {
});
it("should pass the filter to navidrome", async () => {
const q: AlbumQuery = { _index: 0, _count: 100, type: "frequent" };
const q: AlbumQuery = { _index: 0, _count: 100, type: "mostPlayed" };
const result = await navidrome
.generateToken({ username, password })
.then((it) => it as AuthSuccess)
@@ -1595,6 +1597,51 @@ describe("Subsonic", () => {
});
});
});
describe("by starred", () => {
beforeEach(() => {
mockGET
.mockImplementationOnce(() => Promise.resolve(ok(PING_OK)))
.mockImplementationOnce(() =>
Promise.resolve(ok(asArtistsJson([artist])))
)
.mockImplementationOnce(
() =>
// album1 never played
Promise.resolve(ok(getAlbumListJson([[artist, album2]])))
// album3 never played
);
});
it("should pass the filter to navidrome", async () => {
const q: AlbumQuery = { _index: 0, _count: 100, type: "starred" };
const result = await navidrome
.generateToken({ username, password })
.then((it) => it as AuthSuccess)
.then((it) => navidrome.login(it.authToken))
.then((it) => it.albums(q));
expect(result).toEqual({
results: [album2].map(albumToAlbumSummary),
total: 1,
});
expect(axios.get).toHaveBeenCalledWith(`${url}/rest/getArtists`, {
params: asURLSearchParams(authParamsPlusJson),
headers,
});
expect(axios.get).toHaveBeenCalledWith(`${url}/rest/getAlbumList2`, {
params: asURLSearchParams({
...authParamsPlusJson,
type: "highest",
size: 500,
offset: 0,
}),
headers,
});
});
});
});
describe("when the artist has only 1 album", () => {