wkulhanek/bonob
1
0
Fork 0
mirror of https://github.com/wkulhanek/bonob.git synced 2025-12-21 17:33:29 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity

Handling failure to fetch images explicitly and returning 500

Browse Source
This commit is contained in:
simojenki
2021-04-17 14:00:35 +10:00
parent e2692126f4
commit a81e6c931b
2 changed files with 43 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/server.ts
View File

@@ -139,10 +139,9 @@ function server(
.login(authToken)
.then((it) =>
it.scrobble(id).then((scrobbleSuccess) => {
if(scrobbleSuccess)
logger.info(`Scrobbled ${id}`)
else
logger.warn(`Failed to scrobble ${id}....`)
if (scrobbleSuccess) logger.info(`Scrobbled ${id}`);
else logger.warn(`Failed to scrobble ${id}....`);
return it;
})
)
@@ -182,6 +181,13 @@ function server(
} else {
res.status(404).send();
}
})
.catch((e: Error) => {
logger.error(
`Failed fetching image ${type}/${id}/size/${size}: ${e.message}`,
e
);
res.status(500).send();
});
}
});

33
tests/server.test.ts
View File

@@ -553,7 +553,7 @@ describe("server", () => {
describe("when there is a valid access token", () => {
describe("some invalid art type", () => {
it("should return the image and a 200", async () => {
it("should return a 400", async () => {
const res = await request(server)
.get(
`/foo/${albumId}/art/size/180?${BONOB_ACCESS_TOKEN_HEADER}=${accessToken}`
@@ -606,6 +606,22 @@ describe("server", () => {
expect(res.status).toEqual(404);
});
});
describe("when there is an error", () => {
it("should return a 500", async () => {
musicService.login.mockResolvedValue(musicLibrary);
musicLibrary.coverArt.mockRejectedValue("Boom")
const res = await request(server)
.get(
`/artist/${albumId}/art/size/180?${BONOB_ACCESS_TOKEN_HEADER}=${accessToken}`
)
.set(BONOB_ACCESS_TOKEN_HEADER, accessToken);
expect(res.status).toEqual(500);
});
});
});
describe("album art", () => {
@@ -648,6 +664,21 @@ describe("server", () => {
expect(res.status).toEqual(404);
});
});
describe("when there is an error", () => {
it("should return a 500", async () => {
musicService.login.mockResolvedValue(musicLibrary);
musicLibrary.coverArt.mockRejectedValue("Boooooom")
const res = await request(server)
.get(
`/album/${albumId}/art/size/180?${BONOB_ACCESS_TOKEN_HEADER}=${accessToken}`
)
.set(BONOB_ACCESS_TOKEN_HEADER, accessToken);
expect(res.status).toEqual(500);
});
});
});
});
});