wkulhanek/bonob
1
0
Fork 0
mirror of https://github.com/wkulhanek/bonob.git synced 2025-12-21 17:33:29 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity

Add Starred albums

Browse Source
This commit is contained in:
simojenki
2021-04-09 10:56:19 +10:00
parent efe4b4238b
commit a08e92fb35
3 changed files with 60 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/music_service.ts
View File

@@ -94,7 +94,7 @@ export const asResult = <T>([results, total]: [T[], number]) => ({
export type ArtistQuery = Paging;
export type AlbumQueryType = 'alphabeticalByArtist' | 'byGenre' | 'random' | 'recent' | 'frequent' | 'newest';
export type AlbumQueryType = 'alphabeticalByArtist' | 'byGenre' | 'random' | 'recent' | 'frequent' | 'newest' | 'starred';
export type AlbumQuery = Paging & {
type: AlbumQueryType;

14
src/smapi.ts
View File

@@ -419,6 +419,7 @@ function bindSmapiSoapServiceToExpress(
container({ id: "albums", title: "Albums" }),
container({ id: "genres", title: "Genres" }),
container({ id: "randomAlbums", title: "Random" }),
container({ id: "starredAlbums", title: "Starred" }),
container({
id: "recentlyAdded",
title: "Recently Added",
@@ -433,7 +434,7 @@ function bindSmapiSoapServiceToExpress(
}),
],
index: 0,
total: 7,
total: 8,
});
case "artists":
return musicLibrary.artists(paging).then((result) => {
@@ -451,15 +452,20 @@ function bindSmapiSoapServiceToExpress(
...paging,
});
}
case "genre":
return albums({
type: "byGenre",
genre: typeId,
...paging,
});
case "randomAlbums":
return albums({
type: "random",
...paging,
});
case "genre":
case "starredAlbums":
return albums({
type: "byGenre",
genre: typeId,
type: "starred",
...paging,
});
case "recentlyAdded":

50
tests/smapi.test.ts
View File

@@ -542,6 +542,11 @@ describe("api", () => {
id: "randomAlbums",
title: "Random",
},
{
itemType: "container",
id: "starredAlbums",
title: "Starred",
},
{
itemType: "container",
id: "recentlyAdded",
@@ -559,7 +564,7 @@ describe("api", () => {
},
],
index: 0,
total: 7,
total: 8,
})
);
});
@@ -938,6 +943,49 @@ describe("api", () => {
});
});
describe("asking for starred albums", () => {
const albums = [rock2, rock1, pop2];
beforeEach(() => {
musicLibrary.albums.mockResolvedValue({
results: albums,
total: allAlbums.length,
});
});
it("should return some", async () => {
const paging = {
index: 0,
count: 100,
};
const result = await ws.getMetadataAsync({
id: "starredAlbums",
...paging,
});
expect(result[0]).toEqual(
getMetadataResult({
mediaCollection: albums.map((it) => ({
itemType: "album",
id: `album:${it.id}`,
title: it.name,
albumArtURI: defaultAlbumArtURI(rootUrl, accessToken, it),
canPlay: true,
})),
index: 0,
total: 6,
})
);
expect(musicLibrary.albums).toHaveBeenCalledWith({
type: "starred",
_index: paging.index,
_count: paging.count,
});
});
});
describe("asking for recently played albums", () => {
const recentlyPlayed = [rock2, rock1, pop2];