Improve error handling when Navidrome fails

src/navidrome.ts

@@ -367,7 +367,7 @@ export class Navidrome implements MusicService {
       )
       .then((json) => json["subsonic-response"])
       .then((json) => {
-        if (isError(json)) throw json.error._message;
+        if (isError(json)) throw `Navidrome error:${json.error._message}`;
         else return json as unknown as T;
       });
 

src/server.ts

@@ -438,8 +438,7 @@ function server(
         })
         .catch((e: Error) => {
           logger.error(
-            `Failed fetching image ${type}/${id}/size/${size}: ${e.message}`,
+            `Failed fetching image ${type}/${id}/size/${size}`, { cause: e }
-            e
           );
           return res.status(500).send();
         });

src/sonos.ts

@@ -162,7 +162,7 @@ export function autoDiscoverySonos(sonosSeedHost?: string): Sonos {
         }
       })
       .catch((e) => {
-        logger.error(`Failed looking for sonos devices ${e}`);
+        logger.error(`Failed looking for sonos devices`, { cause: e });
         return [];
       });
   };

tests/navidrome.test.ts

@@ -447,7 +447,7 @@ describe("Navidrome", () => {
         });
 
         const token = await navidrome.generateToken({ username, password });
-        expect(token).toEqual({ message: "Wrong username or password" });
+        expect(token).toEqual({ message: "Navidrome error:Wrong username or password" });
       });
     });
   });
@@ -3387,7 +3387,7 @@ describe("Navidrome", () => {
               .then((it) => it as AuthSuccess)
               .then((it) => navidrome.login(it.authToken))
               .then((it) => it.playlist(id))
-          ).rejects.toEqual("data not found");
+          ).rejects.toEqual("Navidrome error:data not found");
         });
       });
 
@@ -3742,7 +3742,7 @@ describe("Navidrome", () => {
       });
     });
 
-    describe("when there id doesnt exist", () => {
+    describe("when the id doesnt exist", () => {
       it("should fail", async () => {
         const id = "idThatHasAnError";
 
@@ -3756,7 +3756,7 @@ describe("Navidrome", () => {
           .generateToken({ username, password })
           .then((it) => it as AuthSuccess)
           .then((it) => navidrome.login(it.authToken))
-          .then((it) => it.similarSongs(id))).rejects.toEqual("data not found");
+          .then((it) => it.similarSongs(id))).rejects.toEqual("Navidrome error:data not found");
       });
     });
   });