wkulhanek/bonob
1
0
Fork 0
mirror of https://github.com/wkulhanek/bonob.git synced 2025-12-21 17:33:29 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity

Similar songs (#18)

Browse Source 
* Support for getting similarSongs from navidrome

* Ability to load topSongs from navidrome

* Load artists not in library from navidrome
This commit is contained in:
Simon J
2021-08-14 09:13:29 +10:00
committed by GitHub
parent 66b6f24e61
commit 43c335ecfc
7 changed files with 576 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

99
tests/smapi.test.ts
View File

@@ -1132,18 +1132,22 @@ describe("api", () => {
});
describe("asking for relatedArtists", () => {
describe("when the artist has many", () => {
describe("when the artist has many, some in the library and some not", () => {
const relatedArtist1 = anArtist();
const relatedArtist2 = anArtist();
const relatedArtist3 = anArtist();
const relatedArtist4 = anArtist();
const relatedArtist5 = anArtist();
const relatedArtist6 = anArtist();
const artist = anArtist({
similarArtists: [
relatedArtist1,
relatedArtist2,
relatedArtist3,
relatedArtist4,
{ ...relatedArtist1, inLibrary: true },
{ ...relatedArtist2, inLibrary: true },
{ ...relatedArtist3, inLibrary: false },
{ ...relatedArtist4, inLibrary: true },
{ ...relatedArtist5, inLibrary: false },
{ ...relatedArtist6, inLibrary: true },
],
});
@@ -1163,8 +1167,8 @@ describe("api", () => {
mediaCollection: [
relatedArtist1,
relatedArtist2,
relatedArtist3,
relatedArtist4,
relatedArtist6,
].map((it) => ({
itemType: "artist",
id: `artist:${it.id}`,
@@ -1193,7 +1197,7 @@ describe("api", () => {
});
expect(result[0]).toEqual(
getMetadataResult({
mediaCollection: [relatedArtist2, relatedArtist3].map(
mediaCollection: [relatedArtist2, relatedArtist4].map(
(it) => ({
itemType: "artist",
id: `artist:${it.id}`,
@@ -1238,6 +1242,44 @@ describe("api", () => {
expect(accessTokens.mint).toHaveBeenCalledWith(authToken);
});
});
describe("when the artist some however none are in the library", () => {
const relatedArtist1 = anArtist();
const relatedArtist2 = anArtist();
const artist = anArtist({
similarArtists: [
{
...relatedArtist1,
inLibrary: false,
},
{
...relatedArtist2,
inLibrary: false,
},
],
});
beforeEach(() => {
musicLibrary.artist.mockResolvedValue(artist);
});
it("should return an empty list", async () => {
const result = await ws.getMetadataAsync({
id: `relatedArtists:${artist.id}`,
index: 0,
count: 100,
});
expect(result[0]).toEqual(
getMetadataResult({
index: 0,
total: 0,
})
);
expect(musicLibrary.artist).toHaveBeenCalledWith(artist.id);
expect(accessTokens.mint).toHaveBeenCalledWith(authToken);
});
});
});
describe("asking for albums", () => {
@@ -1947,12 +1989,19 @@ describe("api", () => {
});
});
describe("when it has similar artists", () => {
describe("when it has similar artists, some in the library and some not", () => {
const similar1 = anArtist();
const similar2 = anArtist();
const similar3 = anArtist();
const similar4 = anArtist();
const artist = anArtist({
similarArtists: [similar1, similar2],
similarArtists: [
{ ...similar1, inLibrary: true },
{ ...similar2, inLibrary: false },
{ ...similar3, inLibrary: false },
{ ...similar4, inLibrary: true },
],
albums: [],
});
@@ -2014,6 +2063,38 @@ describe("api", () => {
});
});
});
describe("when none of the similar artists are in the library", () => {
const relatedArtist1 = anArtist();
const relatedArtist2 = anArtist();
const artist = anArtist({
similarArtists: [
{ ...relatedArtist1, inLibrary: false },
{ ...relatedArtist2, inLibrary: false },
],
albums: [],
});
beforeEach(() => {
musicLibrary.artist.mockResolvedValue(artist);
});
it("should not return a RELATED_ARTISTS browse option", async () => {
const root = await ws.getExtendedMetadataAsync({
id: `artist:${artist.id}`,
index: 0,
count: 100,
});
expect(root[0]).toEqual({
getExtendedMetadataResult: {
// artist has no albums
count: "0",
index: "0",
total: "0",
},
});
});
});
});
describe("asking for a track", () => {