Fix issue where track numbers on playlists were album track numbers rather than playlist track numbers

src/navidrome.ts

@@ -657,31 +657,34 @@ export class Navidrome implements MusicService {
             id,
           })
           .then((it) => it.playlist)
-          .then((playlist) => ({
+          .then((playlist) => {
-            id: playlist._id,
+            let trackNumber = 1;
-            name: playlist._name,
+            return {
-            entries: (playlist.entry || []).map((entry) => ({
+              id: playlist._id,
-              id: entry._id,
+              name: playlist._name,
-              name: entry._title,
+              entries: (playlist.entry || []).map((entry) => ({
-              mimeType: entry._contentType,
+                id: entry._id,
-              duration: parseInt(entry._duration || "0"),
+                name: entry._title,
-              number: parseInt(entry._track || "0"),
+                mimeType: entry._contentType,
-              genre: maybeAsGenre(entry._genre),
+                duration: parseInt(entry._duration || "0"),
-              album: {
+                number: trackNumber++,
-                id: entry._albumId,
-                name: entry._album,
-                year: entry._year,
                 genre: maybeAsGenre(entry._genre),
+                album: {
+                  id: entry._albumId,
+                  name: entry._album,
+                  year: entry._year,
+                  genre: maybeAsGenre(entry._genre),
   
-                artistName: entry._artist,
+                  artistName: entry._artist,
-                artistId: entry._artistId,
+                  artistId: entry._artistId,
-              },
+                },
-              artist: {
+                artist: {
-                id: entry._artistId,
+                  id: entry._artistId,
-                name: entry._artist,
+                  name: entry._artist,
-              },
+                },
-            })),
+              })),
-          })),
+            }
+          }),
     };
 
     return Promise.resolve(musicLibrary);

tests/navidrome.test.ts

@@ -3163,30 +3163,49 @@ describe("Navidrome", () => {
       describe("when there is a playlist with the id", () => {
         describe("and it has tracks", () => {
           it("should return the playlist with entries", async () => {
-            const playlist = aPlaylist({
+            const id = uuid();
-              entries: [
+            const name = "Great Playlist";
-                aTrack({ genre: { id: "pop", name: "pop" } }),
+            const track1 = aTrack({
-                aTrack({ genre: { id: "rock", name: "rock" } }),
+              genre: { id: "pop", name: "pop" },
-              ],
+              number: 66,
+            });
+            const track2 = aTrack({
+              genre: { id: "rock", name: "rock" },
+              number: 77,
             });
 
             mockGET
               .mockImplementationOnce(() => Promise.resolve(ok(PING_OK)))
               .mockImplementationOnce(() =>
-                Promise.resolve(ok(getPlayList(playlist)))
+                Promise.resolve(
+                  ok(
+                    getPlayList({
+                      id,
+                      name,
+                      entries: [track1, track2],
+                    })
+                  )
+                )
               );
 
             const result = await navidrome
               .generateToken({ username, password })
               .then((it) => it as AuthSuccess)
               .then((it) => navidrome.login(it.authToken))
-              .then((it) => it.playlist(playlist.id));
+              .then((it) => it.playlist(id));
 
-            expect(result).toEqual(playlist);
+            expect(result).toEqual({
+              id,
+              name,
+              entries: [
+                { ...track1, number: 1 },
+                { ...track2, number: 2 },
+              ],
+            });
 
             expect(mockGET).toHaveBeenCalledWith(`${url}/rest/getPlaylist`, {
               params: {
-                id: playlist.id,
+                id,
                 ...authParams,
               },
               headers,